HDR WTF ??

Coders forum. Discuss techniques, swap code snippets, ask for help etc. relating to all forms of software development.
User avatar
Harlequin
Baaaaaaa!
Baaaaaaa!
Posts: 6505
Joined: Wed Jun 05, 2002 4:19 am 0
Location: London, directly above the centre of the Earth.

Re: HDR WTF ??

Post by Harlequin »

LSK's snippet is apparently from this sample code described as "Illustrates how to render HDR content, and detect whether the current display supports it." The mysteries of ComPtr<IDXGIOutput6> might be explained within.
Emoticon and contraction free since... quite a while ago.
User avatar
gilesgoat
Sheepie Whore
Sheepie Whore
Posts: 27258
Joined: Wed Sep 03, 2003 7:54 am 0
Location: Monfalcone, Italy
Contact:

Re: HDR WTF ??

Post by gilesgoat »

Harlequin wrote:LSK's snippet is apparently from this sample code described as "Illustrates how to render HDR content, and detect whether the current display supports it." The mysteries of ComPtr<IDXGIOutput6> might be explained within.
Ok the whole sample makes more sense, if you see the snipped LSK posted has nothing to do with HDR, it only enumerates all the present monitors and finds out in which one the window of the currently launched app is present.

Also I don't even know where he got that snippet from, I am looking ( I'll clone them tomorrow ) all the sources in that folder I can't even see where that code comes from.

Sure he did to accidentally pasted something else ?

Ah I see now where that code comes from it's from :

void D3D12HDR::CheckDisplayHDRSupport()
{
}

Sadly of all that code the ONLY LINE THAT REALLY COUNTS and he did NOT paste it's basically see these last ones ..

Code: Select all


    m_hdrSupport = (desc1.ColorSpace == DXGI_COLOR_SPACE_RGB_FULL_G2084_NONE_P2020);

That COMPTR is just a "ptr" to an interface once they established "which one is the monitor the current window is on", which is seems they do by enumerating ALL the monitors they find and then checking one by one if the window is inside that area or outside but that has ABSOLUTELY NOTHING to do with HDR or not HDR.

Anyway I did not mean for him to get it that badly .. I am sorry, I was being sarcastic not angry at him.
Giles the billy goat
"Baa"
User avatar
Harlequin
Baaaaaaa!
Baaaaaaa!
Posts: 6505
Joined: Wed Jun 05, 2002 4:19 am 0
Location: London, directly above the centre of the Earth.

Re: HDR WTF ??

Post by Harlequin »

gilesgoat wrote:Also I don't even know where he got that snippet from, I am looking ( I'll clone them tomorrow ) all the sources in that folder I can't even see where that code comes from.
It was from LSK's initial link: https://learn.microsoft.com/en-us/windo ... amic-range.
Emoticon and contraction free since... quite a while ago.
User avatar
Little stoned kiwi
Baaaaaa!
Baaaaaa!
Posts: 4597
Joined: Mon Oct 27, 2003 6:05 am 0
Location: Christchurch

Re: HDR WTF ??

Post by Little stoned kiwi »

Little stoned kiwi wrote:
gilesgoat wrote: ???! And WHAT MEANS THE MONITOR IS HDR CAPABLE ??
There's a snippet of sample code on the linked page that gets the display the app is being rendered to then works out if HDR is supported from the colorspace:

Code: Select all

...
gilesgoat wrote:Ok the whole sample makes more sense, if you see the snipped LSK posted has nothing to do with HDR, it only enumerates all the present monitors and finds out in which one the window of the currently launched app is present.
:roll:

I spent time reading the document at https://learn.microsoft.com/en-us/windo ... amic-range, and am glad I did for my own education. The first half is theory, I recommend it for anyone that is curious to learn more about what HDR is all about.

Following that is the implementation details, including that snippet of code to detect if the monitor is HDR capable. The snippet of code in that educational guide that has the GitHub link to the repository it was taken from


I don't regret spending time learning more about something I was curious about. What I do regret is spending time on crafting those posts for someone with their head so stuck up their ass they can't take the time to read them or the reference material. Go help your self instead of watching movies you hate and being a condescending prick.
If they think you're crude, go technical; if they think you're technical, go crude. I'm a very technical boy.
User avatar
gilesgoat
Sheepie Whore
Sheepie Whore
Posts: 27258
Joined: Wed Sep 03, 2003 7:54 am 0
Location: Monfalcone, Italy
Contact:

Re: HDR WTF ??

Post by gilesgoat »

Little stoned kiwi wrote:
Little stoned kiwi wrote:
gilesgoat wrote: ???! And WHAT MEANS THE MONITOR IS HDR CAPABLE ??
There's a snippet of sample code on the linked page that gets the display the app is being rendered to then works out if HDR is supported from the colorspace:

Code: Select all

...
gilesgoat wrote:Ok the whole sample makes more sense, if you see the snipped LSK posted has nothing to do with HDR, it only enumerates all the present monitors and finds out in which one the window of the currently launched app is present.
:roll:

I spent time reading the document at https://learn.microsoft.com/en-us/windo ... amic-range, and am glad I did for my own education. The first half is theory, I recommend it for anyone that is curious to learn more about what HDR is all about.

Following that is the implementation details, including that snippet of code to detect if the monitor is HDR capable. The snippet of code in that educational guide that has the GitHub link to the repository it was taken from


I don't regret spending time learning more about something I was curious about. What I do regret is spending time on crafting those posts for someone with their head so stuck up their ass they can't take the time to read them or the reference material. Go help your self instead of watching movies you hate and being a condescending prick.
Hey I said I was sorry, I was begin a bit sarcastic/bored I did not mean for you to take it THAT badly.

Watching movies I hate seems to be "a speciality of mine" I would not be happy if I can't moan about a bad movie ( but likewise I like to spend some time writing about good movies ).

Again I am sorry you took it THAT bad, it wasn't my intention to make you feel bad at all, why would I intentionally want that ? What do I have to gain from ? Nothing !

"condescending" I had to search in a dictionary, I did not even know what the word meant ..

Anyway thanks for your effort.
Giles the billy goat
"Baa"
User avatar
Little stoned kiwi
Baaaaaa!
Baaaaaa!
Posts: 4597
Joined: Mon Oct 27, 2003 6:05 am 0
Location: Christchurch

Re: HDR WTF ??

Post by Little stoned kiwi »

I over-reacted to your response, Giles. The reasons for it are my own which I need to address. Regardless of them, I am responsible for how I react.
In this instance I responded poorly. I said inexcusable, hurtful things that have no place here.

I'm sorry to you and everyone here for acting in such an unseemly manner.

I hope you crack this HDR nut and do wonderful, innovative things with it. The passion to do so is what makes Llamasoft unique and special.
If they think you're crude, go technical; if they think you're technical, go crude. I'm a very technical boy.
User avatar
gilesgoat
Sheepie Whore
Sheepie Whore
Posts: 27258
Joined: Wed Sep 03, 2003 7:54 am 0
Location: Monfalcone, Italy
Contact:

Re: HDR WTF ??

Post by gilesgoat »

Little stoned kiwi wrote:I over-reacted to your response, Giles. The reasons for it are my own which I need to address. Regardless of them, I am responsible for how I react.
In this instance I responded poorly. I said inexcusable, hurtful things that have no place here.

I'm sorry to you and everyone here for acting in such an unseemly manner.

I hope you crack this HDR nut and do wonderful, innovative things with it. The passion to do so is what makes Llamasoft unique and special.
It's all cool man, I think we both over-reacted a bit, as I said to you "my biggest regret was making you mad/sad" :( "Misunderstandings" like this can happen, especially when out heads are so full , of code, and we are all passionate about things.

So no hard feelings, just a glitch from mine and your side, sorry again for making you feel like that *HUGS*.
Giles the billy goat
"Baa"
Post Reply